Skip to content

Reenable tcp filter racetest#3783

Merged
ldemailly merged 4 commits intoistio:masterfrom
xiaolanz:race
Feb 26, 2018
Merged

Reenable tcp filter racetest#3783
ldemailly merged 4 commits intoistio:masterfrom
xiaolanz:race

Conversation

@xiaolanz
Copy link
Copy Markdown
Contributor

@xiaolanz xiaolanz commented Feb 26, 2018 •
edited
Loading

address #3211

@xiaolanz xiaolanz requested review from a team February 26, 2018 19:37
@xiaolanz xiaolanz removed request for a team February 26, 2018 19:37
@xiaolanz xiaolanz removed the approved label Feb 26, 2018
@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Feb 26, 2018

you need to undo your change to vendor (and in general be careful to not add vendor to prs)

# in istio
make pull  # to rebase your PR to latest
cd vendor; git checkout master; git pull; cd ..
# now git status and git diff vendor should show that you're on the latest vendor sha
# commit/update the PR

ldemailly
ldemailly reviewed Feb 26, 2018
View reviewed changes
.gitignore Outdated
samples/bookinfo/consul/bookinfo.sidecars.yaml
samples/bookinfo/eureka/bookinfo.sidecars.yaml
istio.VERSION
/vendor/*
Copy link
Copy Markdown
Member

@ldemailly ldemailly Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure we should do that, some PR do need to update vendor - but maybe indeed this is safer to avoid most accident

@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Feb 26, 2018

/lgtm
but we should have a build to see if it does pass or not

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldemailly

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 26, 2018 •
edited
Loading

Codecov Report

Merging #3783 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #3783    +/-   ##
=======================================
- Coverage      76%     76%   -<1%     
=======================================
  Files         291     291            
  Lines       26930   26955    +25     
=======================================
+ Hits        20441   20448     +7     
- Misses       5183    5198    +15     
- Partials     1306    1309     +3
Impacted Files Coverage Δ
mixer/adapter/stackdriver/stackdriver.go 55% <0%> (-15%) ⬇️
mixer/adapter/opa/opa.go 79% <0%> (-3%) ⬇️
pilot/pkg/model/conversion.go 86% <0%> (-2%) ⬇️
mixer/adapter/servicecontrol/checkprocessor.go 80% <0%> (-2%) ⬇️
mixer/adapter/denier/denier.go 90% <0%> (-2%) ⬇️
pilot/pkg/model/egress_rules.go 95% <0%> (-2%) ⬇️
mixer/adapter/stdio/zap.go 97% <0%> (-1%) ⬇️
pilot/pkg/proxy/envoy/v2/mesh.go 75% <0%> (ø) ⬇️
mixer/adapter/kubernetesenv/kubernetesenv.go 68% <0%> (ø) ⬇️
mixer/adapter/stdio/stdio.go 100% <0%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7b81ec...f486fee. Read the comment docs.

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 26, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@ldemailly ldemailly merged commit 946710b into istio:master Feb 26, 2018
@xiaolanz xiaolanz changed the title [WIP] Reenable tcp filter racetest Reenable tcp filter racetest Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ldemailly ldemailly ldemailly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ldemailly ldemailly

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xiaolanz @ldemailly @istio-merge-robot @googlebot @istio-testing