Istioctl analyze support beta version#37581
Merged
istio-testing merged 3 commits intoistio:masterfrom May 6, 2022
Merged
Conversation
76a421f to
75fd421
Compare
75fd421 to
f40cf5c
Compare
howardjohn
reviewed
Feb 28, 2022
howardjohn
approved these changes
May 5, 2022
| if rs.Resource().GroupVersionKind() == gvk { | ||
| return rs, true | ||
| } | ||
| for _, va := range rs.Resource().GroupVersionAliasKinds() { |
Member
There was a problem hiding this comment.
nit: maybe GroupVersionAliasKinds should just return ALL versions, not just aliases. Would make this slightly simpler and I think a bit easier to use
Contributor
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
Take over #37398.
/cc @therealmitchconnors
Proposal: https://docs.google.com/document/d/1C6cpA7V240EPRCDxU19jfqMWWqseaHM-welmmotAVoY/edit?usp=sharing&resourcekey=0-9Il9oisoqX5oh8x9yScBXA
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.
Please check any characteristics that apply to this pull request.