Fix typo pipline -> pipeline by hklai · Pull Request #3698 · istio/istio

hklai · 2018-02-22T20:23:29Z

No description provided.

istio-merge-robot · 2018-02-22T20:23:49Z

@hklai PR needs rebase

yutongz

/lgtm

mattdelco · 2018-02-22T20:26:40Z

release/pipeline/configs/environment_config.py

    MFEST_COMMIT='master@{{{timestamp}}}',
    VERSION='{major}.{minor}.{patch}-pre{date}-{rc}',
-    GCS_BUILD_BUCKET='istio-release-pipline-data',
+    GCS_BUILD_BUCKET='istio-release-pipeline-data',


Be sure to create the bucket.

Line 46 also has an instance of "pipline", but it's too far away from any other change for github to allow me to comment on it.

Yes I have already created the bucket.

Also updated line 46. Failed to take care of the capital P when I grepped.

Hrm, the bucket didn't exist when I made the comment. Anyway, it does seem to exist now. I'm not sure if the location matters, but for now I'm doing to assume that multi-regional is a strict superset of a specific region (which is what the original used).

in which project was the bucket created ?

istio-release. This is also the project used for running the daily builds

istio-merge-robot · 2018-02-22T22:22:51Z

/lgtm cancel //PR changed after LGTM, removing LGTM. @hklai @yutongz

yutongz · 2018-02-23T02:30:07Z

/lgtm

istio-merge-robot · 2018-02-23T03:34:36Z

@hklai PR needs rebase

hklai · 2018-02-26T20:51:18Z

/open

istio-merge-robot · 2018-02-26T22:57:34Z

/lgtm cancel //PR changed after LGTM, removing LGTM. @hklai @yutongz

yutongz · 2018-02-26T22:59:13Z

/lgtm

hklai · 2018-02-26T23:00:22Z

/approve

rkpagadala · 2018-02-26T23:02:20Z

/lgtm

istio-merge-robot · 2018-02-26T23:02:36Z

/lgtm cancel //PR changed after LGTM, removing LGTM. @hklai @rkpagadala @yutongz

yutongz · 2018-02-26T23:08:45Z

/lgtm

mattdelco · 2018-02-26T23:09:01Z

/lgtm
though you can also kill a second bird with this stone by fixing the 4 instances of "quilification" in pipline/dags/istio_common_dag.py.

codecov · 2018-02-26T23:20:27Z

Codecov Report

Merging #3698 into master will increase coverage by 1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #3698    +/-   ##
=======================================
+ Coverage      76%     77%    +1%     
=======================================
  Files         291     291            
  Lines       26952   26374   -578     
=======================================
- Hits        20461   20100   -361     
+ Misses       5183    5019   -164     
+ Partials     1308    1255    -53

Impacted Files	Coverage Δ
mixer/adapter/solarwinds/log_handler.go	`58% <0%> (-11%)`	⬇️
mixer/adapter/list/regexList.go	`69% <0%> (-9%)`	⬇️
security/pkg/platform/gcp.go	`95% <0%> (-5%)`	⬇️
mixer/adapter/stackdriver/metric/distribution.go	`83% <0%> (-4%)`	⬇️
mixer/adapter/prometheus/prometheus.go	`80% <0%> (-3%)`	⬇️
mixer/adapter/redisquota/redisquota.go	`86% <0%> (-3%)`	⬇️
mixer/adapter/servicecontrol/servicecontrol.go	`59% <0%> (-3%)`	⬇️
...olarwinds/internal/papertrail/papertrail_logger.go	`59% <0%> (-3%)`	⬇️
mixer/tools/adapterlinter/main.go	`81% <0%> (-1%)`	⬇️
mixer/adapter/list/ipList.go	`100% <0%> (ø)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 946710b...5786a23. Read the comment docs.

istio-merge-robot · 2018-02-26T23:24:36Z

/test all [submit-queue is verifying that this PR is safe to merge]

istio-merge-robot · 2018-02-26T23:28:35Z

/lgtm cancel //PR changed after LGTM, removing LGTM. @hklai @mattdelco @rkpagadala @yutongz

mattdelco · 2018-02-26T23:29:32Z

/lgtm

rkpagadala · 2018-02-26T23:30:16Z

/lgtm

istio-merge-robot · 2018-02-26T23:30:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hklai, mattdelco, rkpagadala, yutongz

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

~~release/pipeline/OWNERS~~ [hklai,mattdelco,rkpagadala]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

istio-merge-robot · 2018-02-26T23:50:16Z

/test all [submit-queue is verifying that this PR is safe to merge]

istio-merge-robot · 2018-02-27T00:10:18Z

Automatic merge from submit-queue.

hklai added 2 commits February 22, 2018 12:17

Fix typo

767cdc0

Fix more typo

ef14960

hklai requested a review from a team February 22, 2018 20:23

googlebot added the cla: yes label Feb 22, 2018

istio-merge-robot added the needs-rebase Indicates a PR needs to be rebased before being merged label Feb 22, 2018

yutongz approved these changes Feb 22, 2018

View reviewed changes

istio-testing assigned yutongz Feb 22, 2018

istio-testing added the lgtm label Feb 22, 2018

mattdelco reviewed Feb 22, 2018

View reviewed changes

istio-merge-robot removed the lgtm label Feb 22, 2018

istio-testing added the lgtm label Feb 23, 2018

istio-merge-robot removed the needs-rebase Indicates a PR needs to be rebased before being merged label Feb 23, 2018

istio-merge-robot added the needs-rebase Indicates a PR needs to be rebased before being merged label Feb 23, 2018

hklai closed this Feb 26, 2018

hklai force-pushed the hklai-airflow branch from f98b910 to dd62fc7 Compare February 26, 2018 20:49

hklai added 2 commits February 26, 2018 14:49

Merge remote-tracking branch 'origin/master' into hklai-airflow

bf3f8b5

Fix OW?NERS

6830dd8

hklai reopened this Feb 26, 2018

istio-merge-robot removed lgtm needs-rebase Indicates a PR needs to be rebased before being merged labels Feb 26, 2018

istio-testing added the lgtm label Feb 26, 2018

istio-merge-robot added the approved label Feb 26, 2018

Update environment_config.py

ac879f4

istio-testing assigned rkpagadala Feb 26, 2018

istio-merge-robot removed the lgtm label Feb 26, 2018

istio-testing added the lgtm label Feb 26, 2018

istio-testing assigned mattdelco Feb 26, 2018

fix quillification to qualification

5786a23

istio-merge-robot removed the lgtm label Feb 26, 2018

istio-testing added the lgtm label Feb 26, 2018

istio-merge-robot merged commit 893fe73 into master Feb 27, 2018

ldemailly deleted the hklai-airflow branch March 8, 2018 01:42

Conversation

hklai commented Feb 22, 2018

Uh oh!

istio-merge-robot commented Feb 22, 2018

Uh oh!

yutongz left a comment

Choose a reason for hiding this comment

Uh oh!

mattdelco Feb 22, 2018

Choose a reason for hiding this comment

Uh oh!

mattdelco Feb 22, 2018

Choose a reason for hiding this comment

Uh oh!

hklai Feb 22, 2018

Choose a reason for hiding this comment

Uh oh!

mattdelco Feb 23, 2018

Choose a reason for hiding this comment

Uh oh!

sebastienvas Feb 23, 2018

Choose a reason for hiding this comment

Uh oh!

mattdelco Feb 23, 2018

Choose a reason for hiding this comment

Uh oh!

istio-merge-robot commented Feb 22, 2018

Uh oh!

yutongz commented Feb 23, 2018

Uh oh!

istio-merge-robot commented Feb 23, 2018

Uh oh!

hklai commented Feb 26, 2018

Uh oh!

istio-merge-robot commented Feb 26, 2018

Uh oh!

yutongz commented Feb 26, 2018

Uh oh!

hklai commented Feb 26, 2018

Uh oh!

rkpagadala commented Feb 26, 2018

Uh oh!

istio-merge-robot commented Feb 26, 2018

Uh oh!

yutongz commented Feb 26, 2018

Uh oh!

mattdelco commented Feb 26, 2018

Uh oh!

codecov bot commented Feb 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

istio-merge-robot commented Feb 26, 2018

Uh oh!

istio-merge-robot commented Feb 26, 2018

Uh oh!

mattdelco commented Feb 26, 2018

Uh oh!

rkpagadala commented Feb 26, 2018

Uh oh!

istio-merge-robot commented Feb 26, 2018

Uh oh!

istio-merge-robot commented Feb 26, 2018

Uh oh!

istio-merge-robot commented Feb 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

codecov bot commented Feb 26, 2018 •

edited

Loading