use proxy version from Dockerfile, don't prepend GCS_PATH#3676
use proxy version from Dockerfile, don't prepend GCS_PATH#3676istio-merge-robot merged 1 commit intoistio:masterfrom rkpagadala:master
Conversation
| @@ -62,7 +62,7 @@ done | |||
|
|
|||
| DEFAULT_GCS_PATH="https://storage.googleapis.com/istio-release/releases/${TAG_NAME}" | |||
There was a problem hiding this comment.
It seems like the "https://storage.googleapis.com/" should also be removed from the DEFAULT_GCS_PATH line.
I assume this change has to do with the "ISTIO_URL" line in the Makefile. An alternative is to use "ISTIO_URL=$TEST_PATH" rather than "ISTIO_GCS=$TEST_PATH" in this script, but I suppose ISTIO_GCS is more appropriate since the motivation for the ISTIO_URL option was to provide a way for people to be able to do a build without relying on GCS.
|
sgtm but how do you test/know that it works ? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ldemailly The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
|
The most straightforward test is to run: mkdir /tmp/scratch release/cloud_builder.sh -b -c -h gcr-hub -p gcs-bucket/gcs-path -o /tmp/scratch and then look at the istio.VERSION in the tar files in /tmp/scratch (specifically the test tars for this change). I'm okay with the change, though the default could be fixed too (though in the common cases the default isn't used). |
No description provided.