remove a flaky / incorrect test#3656
Merged
istio-merge-robot merged 1 commit intoistio:masterfrom Feb 21, 2018
Merged
Conversation
As reported, the test case TestQueueCancelSync is flakey, but actually that's because the test case is based on a wrong assumption. The test case assumes that `select` chooses the clause of `donec` after closing it, but there's a race condition that another clause becomes selectable, which makes this test flaky. By considering these things, this test case should be rather removed. Fixes istio#3646
Contributor
Author
|
/assign @ldemailly |
Member
|
hmm so no test at all ? /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ldemailly The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Collaborator
|
@jmuk: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported, the test case TestQueueCancelSync is flakey, but
actually that's because the test case is based on a wrong assumption. The test case
assumes that
selectchooses the clause ofdonecafter closingit, but there's a race condition that another clause can proceed
(and can be chosen), which causes the flake.
By considering this, the test case should be rather removed.
Fixes #3646