Skip to content

Update istio release alert email destination#3640

Merged
istio-merge-robot merged 1 commit intomasterfrom
hklai-release
Feb 21, 2018
Merged

Update istio release alert email destination#3640
istio-merge-robot merged 1 commit intomasterfrom
hklai-release

Conversation

@hklai
Copy link
Copy Markdown
Contributor

@hklai hklai commented Feb 21, 2018

No description provided.

@hklai hklai requested a review from a team February 21, 2018 07:29
@hklai hklai requested a review from rkpagadala February 21, 2018 07:29
ldemailly
ldemailly approved these changes Feb 21, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

am I in that list ?

@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Feb 21, 2018

/lgtm

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 21, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldemailly

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@hklai
Copy link
Copy Markdown
Contributor Author

hklai commented Feb 21, 2018

This change will have to be pushed to airflow to take effect, which i will do later today.

@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Feb 21, 2018

/retest

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 21, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 21, 2018

Automatic merge from submit-queue.

@istio-merge-robot istio-merge-robot merged commit 6530aff into master Feb 21, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 21, 2018

@hklai: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-e2e.sh addbd42 link /test istio-pilot-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly ldemailly deleted the hklai-release branch February 22, 2018 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rkpagadala rkpagadala Awaiting requested review from rkpagadala

1 more reviewer

@ldemailly ldemailly ldemailly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ldemailly ldemailly

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hklai @ldemailly @istio-merge-robot @istio-testing @googlebot