Skip to content

Update path for START_ENVOY#3638

Merged
mandarjog merged 2 commits intoistio:masterfrom
mandarjog:fix_int
Feb 21, 2018
Merged

Update path for START_ENVOY#3638
mandarjog merged 2 commits intoistio:masterfrom
mandarjog:fix_int

Conversation

@mandarjog
Copy link
Copy Markdown
Contributor

@mandarjog mandarjog commented Feb 21, 2018

Proxy paths changed.

Update path per proxy change.

istio/proxy@024f8d9

Signed-off-by: Mandar U Jog mjog@google.com

@mandarjog
Update path for START_ENVOY
f39a5a5 
Proxy paths changed.

Signed-off-by: Mandar U Jog <mjog@google.com>
@mandarjog mandarjog requested review from a team and ldemailly February 21, 2018 06:20
@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Feb 21, 2018

thanks a lot for fixing this, but how did the breaking PR got in ? cc @hklai

/lgtm

@wattli
Copy link
Copy Markdown
Contributor

wattli commented Feb 21, 2018

/lgtm

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 21, 2018

/lgtm cancel //PR changed after LGTM, removing LGTM. @ldemailly @mandarjog @wattli

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 21, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldemailly, wattli

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@mandarjog
Copy link
Copy Markdown
Contributor Author

mandarjog commented Feb 21, 2018

The problem is that istio/istio integration tests uses part of istio/proxy without pinning it to a specific version. I have updated it to use pinned version.

@mandarjog mandarjog merged commit 748f193 into istio:master Feb 21, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 21, 2018

@mandarjog: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-presubmit.sh f10ad9f link /test istio-presubmit
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Feb 21, 2018

I wonder if go dep could also maintain the proxy in vendor/

@ldemailly ldemailly mentioned this pull request Feb 21, 2018
Merged
@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Feb 21, 2018

why u no wait for the tests before merging ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldemailly ldemailly Awaiting requested review from ldemailly

Assignees

@ldemailly ldemailly

@wattli wattli

Labels

kind/test failure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mandarjog @ldemailly @wattli @istio-merge-robot @istio-testing @googlebot