Skip to content

Fix the isUds logic#3630

Merged
wattli merged 6 commits intoistio:masterfrom
wattli:codecov
Feb 21, 2018
Merged

Fix the isUds logic#3630
wattli merged 6 commits intoistio:masterfrom
wattli:codecov

Conversation

@wattli
Copy link
Copy Markdown
Contributor

@wattli wattli commented Feb 20, 2018

No description provided.

@wattli wattli requested review from a team and myidpt February 20, 2018 23:58
@myidpt
Copy link
Copy Markdown

myidpt commented Feb 21, 2018

/lgtm
/approve

@istio-merge-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: myidpt

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link
Copy Markdown

/lgtm cancel //PR changed after LGTM, removing LGTM. @myidpt @wattli

@istio-testing
Copy link
Copy Markdown
Collaborator

@wattli: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-e2e.sh 4ff4ef5 link /test istio-pilot-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wattli wattli merged commit 5d68200 into istio:master Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants