Merged
Conversation
noticed that "tests" is specified in lintconfig_base.json incorrectly. It's "test" actually. By changing this, I've met some new lint errors in test.go files, mostly on errcheck. This PR includes fixes on them. Note: I've seen several patterns of `defer something.Close()`, which does not check the errors. I think this is very common among our code base, and I don't think this has problem if that's within test code. I added an exclude pattern for this.
ldemailly
approved these changes
Feb 20, 2018
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ldemailly The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
wattli
approved these changes
Feb 20, 2018
|
/test all [submit-queue is verifying that this PR is safe to merge] |
geeknoid
approved these changes
Feb 20, 2018
|
Automatic merge from submit-queue. |
Collaborator
|
@jmuk: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noticed that "tests" is specified in lintconfig_base.json incorrectly.
It's "test" actually.
By changing this, I've met some new lint errors in test.go files,
mostly on errcheck. This PR includes fixes on them.
Note: I've seen several patterns of
defer something.Close(),which does not check the errors. I think this is very common among
our code base, and I don't think this has problem if that's within
test code. I added an exclude pattern for this.