Skip to content

Update ON-CALL.md#3622

Merged
ldemailly merged 1 commit intomasterfrom
ldemailly-patch-1
Feb 22, 2018
Merged

Update ON-CALL.md#3622
ldemailly merged 1 commit intomasterfrom
ldemailly-patch-1

Conversation

@ldemailly
Copy link
Copy Markdown
Member

@ldemailly ldemailly commented Feb 20, 2018

No description provided.

@ldemailly ldemailly requested review from a team and GregHanson February 20, 2018 21:55
@ldemailly ldemailly mentioned this pull request Feb 21, 2018
Closed
@ldemailly
Copy link
Copy Markdown
Member Author

ldemailly commented Feb 21, 2018

/test e2e-simple

@ldemailly
Copy link
Copy Markdown
Member Author

ldemailly commented Feb 21, 2018

/test istio-pilot-e2e

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 21, 2018

@ldemailly: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-e2e.sh 9ea8707 link /test istio-pilot-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson
Copy link
Copy Markdown
Member

GregHanson commented Feb 22, 2018

/lgtm

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 22, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GregHanson
We suggest the following additional approver: sebastienvas

Assign the PR to them by writing /assign @sebastienvas in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@ldemailly ldemailly merged commit f7a5071 into master Feb 22, 2018
@ldemailly ldemailly deleted the ldemailly-patch-1 branch February 22, 2018 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@GregHanson GregHanson GregHanson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@GregHanson GregHanson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ldemailly @istio-testing @GregHanson @istio-merge-robot @googlebot