Skip to content

Added probe settings for ca#3620

Merged
myidpt merged 5 commits intoistio:masterfrom
mangchiandjjoe:ca_probe_install_yaml
Feb 20, 2018
Merged

Added probe settings for ca#3620
myidpt merged 5 commits intoistio:masterfrom
mangchiandjjoe:ca_probe_install_yaml

Conversation

@mangchiandjjoe
Copy link
Copy Markdown
Contributor

@mangchiandjjoe mangchiandjjoe commented Feb 20, 2018

No description provided.

@mangchiandjjoe mangchiandjjoe self-assigned this Feb 20, 2018
@mangchiandjjoe mangchiandjjoe requested review from a team and myidpt February 20, 2018 21:22
@myidpt
Copy link
Copy Markdown

myidpt commented Feb 20, 2018 •
edited
Loading

Thanks a ton for the work!
Can we put this config to a single template:
install/kubernetes/templates/istio-ca-with-health-check.yaml.tmpl (I think in this PR you just need to create this file).
And then we can put together these templates with health check into a file:
isito-auth-with-control-plane-health-check.yaml.
This an alpha feature that we don't want to enable by default.
Also see the comments in #3335.

myidpt
myidpt reviewed Feb 20, 2018
View reviewed changes
install/kubernetes/templates/istio-ca.yaml.tmpl Outdated
- --grpc-port=8060
- --grpc-hostname=istio-ca
- --self-signed-ca=true
- --liveness-probe-path=/usr/local/bin/ca.liveness # path to the liveness health check status file
Copy link
Copy Markdown

@myidpt myidpt Feb 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change it to /tmp/ca.liveness?

Copy link
Copy Markdown
Contributor Author

@mangchiandjjoe mangchiandjjoe Feb 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed

install/kubernetes/templates/istio-ca.yaml.tmpl Outdated
- /usr/local/bin/istio_ca
- probe
- --probe-path=/usr/local/bin/ca.liveness # path to the liveness health check status file
- --interval=125s # maximum duration that passed since last check before health check restart the pod
Copy link
Copy Markdown

@myidpt myidpt Feb 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change it to:
# the maximum time gap allowed between the file mtime and the current sys clock.

Copy link
Copy Markdown
Contributor Author

@mangchiandjjoe mangchiandjjoe Feb 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@mangchiandjjoe mangchiandjjoe requested a review from a team February 20, 2018 23:05
@myidpt
Copy link
Copy Markdown

myidpt commented Feb 20, 2018

/lgtm
/approve

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 20, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myidpt
We suggest the following additional approver: ldemailly

Assign the PR to them by writing /assign @ldemailly in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@myidpt myidpt merged commit 41ad6c1 into istio:master Feb 20, 2018
@myidpt myidpt mentioned this pull request Feb 21, 2018
Merged
@myidpt myidpt changed the title Added default probe settings for ca Added probe settings for ca Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@myidpt myidpt myidpt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@myidpt myidpt

@mangchiandjjoe mangchiandjjoe

Labels

area/security kind/enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mangchiandjjoe @myidpt @istio-merge-robot @googlebot @istio-testing