Skip to content

Disable vm test in cluster wide#3613

Merged
istio-merge-robot merged 1 commit intoistio:masterfrom
sebastienvas:cluster-wide
Feb 21, 2018
Merged

Disable vm test in cluster wide#3613
istio-merge-robot merged 1 commit intoistio:masterfrom
sebastienvas:cluster-wide

Conversation

@sebastienvas
Copy link
Copy Markdown
Contributor

Cluster provisioning is enabled on cluster wide test, and vm test has not been updated to use the pre-provisioned VM and is creating instead a VM in the main testing project. The VM test is using local network IP, and the cluster and the VM are not in the same project which makes communication between those 2 impossible.

Disabling the vm test for now until we can take advantage of the provisioned VM

@sebastienvas sebastienvas requested a review from a team February 20, 2018 18:35
@sebastienvas sebastienvas requested a review from chxchx February 20, 2018 18:35

echo 'Running cluster-wide e2e rbac, auth Tests'
${ROOT}/prow/e2e-suite-rbac-auth.sh --cluster_wide "$@"
${ROOT}/prow/e2e-suite.sh --auth_enable --cluster_wide "$@"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the title since this seems to enable VM test?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no if you look at e2e-suite-rbac-auth.sh, it s calling ./prow/e2e-suite.sh --test_vm --auth_enable "$@"
I am just calling ./prow/e2e-suite.sh directly and dropping the --test_vm

@sebastienvas
Copy link
Copy Markdown
Contributor Author

/test istio-pilot-e2e

@chxchx
Copy link
Copy Markdown
Contributor

chxchx commented Feb 20, 2018

/lgtm

@istio-merge-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chxchx

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link
Copy Markdown

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link
Copy Markdown

Automatic merge from submit-queue.

@istio-merge-robot istio-merge-robot merged commit c36096a into istio:master Feb 21, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

@sebastienvas: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-e2e.sh 4579805 link /test istio-pilot-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants