Merged
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:You can indicate your approval by writing |
ec6db34 to
04dff3e
Compare
04dff3e to
ebfb2a0
Compare
guptasu
approved these changes
Feb 16, 2018
Contributor
guptasu
left a comment
There was a problem hiding this comment.
Any ideas if we can restrict APAs from editing the fields directly and force them to use the Set methods ?
Contributor
|
@douglas-reid @geeknoid @mandarjog I am merging this PR since without this mixer test starts to fail when I do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completes the work started in PR #3530. It switches from GoName to ProtoName
for field-checking and adds some more tests to the il packages to check on behavior
of
emptyStringMap.Most of the code changes are directly related to running
go generate ./mixer/....