Skip to content

Add option to install GCE VM#3535

Merged
wattli merged 1 commit intoistio:masterfrom
wattli:rawvm
Feb 15, 2018
Merged

Add option to install GCE VM#3535
wattli merged 1 commit intoistio:masterfrom
wattli:rawvm

Conversation

@wattli
Copy link
Copy Markdown
Contributor

@wattli wattli commented Feb 15, 2018

No description provided.

@wattli wattli requested review from a team, costinm and ldemailly February 15, 2018 22:09
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 15, 2018 •
edited
Loading

@wattli: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-smoke.sh 506fe43 link /test e2e-smoke
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wattli wattli requested a review from myidpt February 15, 2018 22:53
myidpt
myidpt approved these changes Feb 15, 2018
View reviewed changes
Copy link
Copy Markdown

@myidpt myidpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this!

@myidpt
Copy link
Copy Markdown

myidpt commented Feb 15, 2018 •
edited
Loading

/lgtm

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 15, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myidpt
We suggest the following additional approver: linsun

Assign the PR to them by writing /assign @linsun in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@wattli wattli merged commit ccb7f9e into istio:master Feb 15, 2018
costinm
costinm reviewed Feb 15, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@costinm costinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this actually does - but the expected behavior is for users to install the .deb file (or at some point have it pre-installed) and things to just work.

This script is mainly for testing - there are many better ways to deploy .deb files.

@costinm
Copy link
Copy Markdown
Contributor

costinm commented Feb 15, 2018

In other words - for gce we should just document that the cert generation / distribution step is no longer needed.

ldemailly
ldemailly reviewed Feb 17, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx !
ps: please add me as reviewer for these as it took me weeks to get them working back in 0.2patches - thanks for taking on the good fight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@costinm costinm costinm left review comments

+2 more reviewers

@ldemailly ldemailly ldemailly left review comments

@myidpt myidpt myidpt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@myidpt myidpt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@wattli @istio-testing @myidpt @istio-merge-robot @costinm @ldemailly @googlebot