Skip to content

When installing via GCP/GKE, wait for initializer/injector to deploy before proceeding with bookinfo#3528

Merged
ldemailly merged 1 commit intoistio:masterfrom
selmanj:wait_on_istio_initializer
Feb 18, 2018
Merged

When installing via GCP/GKE, wait for initializer/injector to deploy before proceeding with bookinfo#3528
ldemailly merged 1 commit intoistio:masterfrom
selmanj:wait_on_istio_initializer

Conversation

@selmanj
Copy link
Copy Markdown
Contributor

@selmanj selmanj commented Feb 15, 2018

Fixes the issue reported in istio/old_issues_repo#207, which happens in regions that tend to operate slower.

@selmanj selmanj requested a review from a team February 15, 2018 19:35
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 15, 2018

Hi @selmanj. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@selmanj selmanj changed the title Wait for initializer/injector to deploy before proceeding with bookinfo When installing via GCP/GKE, wait for initializer/injector to deploy before proceeding with bookinfow Feb 15, 2018
@selmanj selmanj changed the title When installing via GCP/GKE, wait for initializer/injector to deploy before proceeding with bookinfow When installing via GCP/GKE, wait for initializer/injector to deploy before proceeding with bookinfo Feb 15, 2018
@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Feb 18, 2018

/lgtm

@ldemailly ldemailly merged commit 673104f into istio:master Feb 18, 2018
@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 18, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldemailly

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 18, 2018

@selmanj: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-e2e.sh b6b2cf0 link /test istio-pilot-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ldemailly ldemailly ldemailly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ldemailly ldemailly

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@selmanj @istio-testing @ldemailly @istio-merge-robot @googlebot