Fix Grafana graphs by filtering the unknown service.#3524
Fix Grafana graphs by filtering the unknown service.#3524istio-merge-robot merged 1 commit intoistio:masterfrom
Conversation
|
Hi @jeffmendoza. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/assign @douglas-reid |
|
Cool. Thanks for doing this. I was about to add this to my PR (#3530) that was related to cleaning up the data generation, but this should be independent. |
|
/ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: douglas-reid The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/test istio-pilot-e2e |
2 similar comments
|
/test istio-pilot-e2e |
|
/test istio-pilot-e2e |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/test e2e-simple |
|
@jeffmendoza: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Automatic merge from submit-queue. |
The new behavior is that an "unknown" service is logging metrics as ingress to
istio-ingress.istio-system. This filters that.Now
istio-ingressshows up as it's own service w/ graphs, but some don't work with the traffic coming from "unknown". I'll keep working on that, but at least this change fixes the whole page not working from the "unknown" service showing up in the selector at the top.