Skip to content

Move key/cert under security dir#3520

Merged
wattli merged 1 commit intoistio:masterfrom
wattli:newb
Feb 15, 2018
Merged

Move key/cert under security dir#3520
wattli merged 1 commit intoistio:masterfrom
wattli:newb

Conversation

@wattli
Copy link
Copy Markdown
Contributor

@wattli wattli commented Feb 15, 2018

The built release package does not take the key/cert, so we still need to put them under security dir

@wattli wattli requested review from a team and myidpt February 15, 2018 18:21
@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 15, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: wenchenglu

Assign the PR to them by writing /assign @wenchenglu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

myidpt
myidpt approved these changes Feb 15, 2018
View reviewed changes
Copy link
Copy Markdown

@myidpt myidpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!

@myidpt
Copy link
Copy Markdown

myidpt commented Feb 15, 2018

Please also change the corresponding file paths here:
https://istio.io/docs/tasks/security/plugin-ca-cert.html#plugging-in-the-existing-certificate-and-key

@wattli wattli merged commit 00daf8a into istio:master Feb 15, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 15, 2018 •
edited
Loading

@wattli: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-e2e.sh dfe828f link /test istio-pilot-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wattli wattli mentioned this pull request Feb 15, 2018
Merged
@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Feb 15, 2018

why are we moving things around ?
why not update the release script ?

@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Feb 15, 2018

also please don't merge before prow finishes unless there is an emergency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@myidpt myidpt myidpt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wattli @istio-merge-robot @myidpt @istio-testing @ldemailly @googlebot