Change mock services to use separate port object#3494
Merged
istio-merge-robot merged 3 commits intoistio:masterfrom Feb 20, 2018
Merged
Change mock services to use separate port object#3494istio-merge-robot merged 3 commits intoistio:masterfrom
istio-merge-robot merged 3 commits intoistio:masterfrom
Conversation
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
…httpport which cause incorrect result when modifying the port for testing (e.g adding annotation)
Contributor
Author
|
/retest |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rkpagadala The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, HelloService and WorldService mock sharing the PortHttp object. This cause incorrect behavior when modifying this port for testing (e.g adding auth annotation), as the change will be applied to both services instead of just the desired one.