Skip to content

Remove obsolete mixer deployment files.#3415

Merged
istio-merge-robot merged 1 commit intoistio:masterfrom
jeffmendoza:cleanup
Feb 16, 2018
Merged

Remove obsolete mixer deployment files.#3415
istio-merge-robot merged 1 commit intoistio:masterfrom
jeffmendoza:cleanup

Conversation

@jeffmendoza
Copy link
Copy Markdown
Contributor

@jeffmendoza jeffmendoza commented Feb 12, 2018

Up to date deployment files are under install/kubernetes. These are
out of date and cause confusion.

@jeffmendoza jeffmendoza requested review from a team February 12, 2018 20:38
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 12, 2018

Hi @jeffmendoza. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jeffmendoza
Copy link
Copy Markdown
Contributor Author

jeffmendoza commented Feb 12, 2018

/assign @douglas-reid

douglas-reid
douglas-reid reviewed Feb 12, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@douglas-reid douglas-reid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@douglas-reid
Copy link
Copy Markdown
Contributor

douglas-reid commented Feb 12, 2018

Thanks for handling this cleanup!

@jeffmendoza
Copy link
Copy Markdown
Contributor Author

jeffmendoza commented Feb 12, 2018

@douglas-reid Can you trigger a retest when you have a chance? Thanks.

@jeffmendoza
Remove obsolete mixer deployment files.
af097d6 
Up to date deployment files are under install/kubernetes. These are
out of date and cause confusion.
@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 14, 2018

/lgtm cancel //PR changed after LGTM, removing LGTM. @douglas-reid @jeffmendoza

@jeffmendoza
Copy link
Copy Markdown
Contributor Author

jeffmendoza commented Feb 14, 2018

@douglas-reid rebased

@sdake
Copy link
Copy Markdown
Member

sdake commented Feb 14, 2018

/ok-to-test

@douglas-reid
Copy link
Copy Markdown
Contributor

douglas-reid commented Feb 16, 2018

/lgtm

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: douglas-reid

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 16, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 16, 2018

Automatic merge from submit-queue.

@istio-merge-robot istio-merge-robot merged commit ded0ab8 into istio:master Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@douglas-reid douglas-reid douglas-reid left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@douglas-reid douglas-reid

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jeffmendoza @istio-testing @douglas-reid @istio-merge-robot @sdake @googlebot