Skip to content

cherry-pick: do not update root certs for destination rule certs (#27268)#28273

Merged
istio-testing merged 1 commit intoistio:release-1.7from
yskopets:cherry-pick/pilot-agent-root-ca-fix
Nov 4, 2020
Merged

cherry-pick: do not update root certs for destination rule certs (#27268)#28273
istio-testing merged 1 commit intoistio:release-1.7from
yskopets:cherry-pick/pilot-agent-root-ca-fix

Conversation

@yskopets
Copy link
Copy Markdown
Member

@yskopets yskopets commented Oct 26, 2020 •
edited
Loading

Signed-off-by: Yaroslav Skopets yaroslav@tetrate.io

Summary

@ramaraochavali @yskopets
do not update root certs for destination rule certs (istio#27268)
a59fcac 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@yskopets yskopets requested a review from a team October 26, 2020 16:10
@google-cla
Copy link
Copy Markdown

google-cla bot commented Oct 26, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Oct 26, 2020
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 26, 2020
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Oct 26, 2020

Hi @yskopets. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yskopets
Copy link
Copy Markdown
Member Author

yskopets commented Oct 26, 2020

@googlebot I consent.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Oct 26, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@yskopets
Copy link
Copy Markdown
Member Author

yskopets commented Oct 26, 2020

@ramaraochavali Could you please consent to cherry-picking your PR #27268 into release-1.7 ?

@yskopets
Copy link
Copy Markdown
Member Author

yskopets commented Oct 26, 2020

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Oct 26, 2020
@yskopets yskopets added the release-notes-none Indicates a PR that does not require release notes. label Oct 26, 2020
@yskopets
Copy link
Copy Markdown
Member Author

yskopets commented Oct 26, 2020

/test release-notes_istio_release-1.7

@yskopets
Copy link
Copy Markdown
Member Author

yskopets commented Oct 26, 2020

/test unit-tests_istio_release-1.7

@howardjohn howardjohn added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Nov 3, 2020
howardjohn
howardjohn approved these changes Nov 3, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @JimmyCYJ

@howardjohn howardjohn mentioned this pull request Nov 3, 2020
Closed
@istio-testing istio-testing merged commit daeff09 into istio:release-1.7 Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@howardjohn howardjohn howardjohn approved these changes

+1 more reviewer

@Mythra Mythra Mythra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yskopets @istio-testing @howardjohn @Mythra @ramaraochavali