Performance: remove legacy global edsClusters#21917
Merged
istio-testing merged 6 commits intoistio:masterfrom Mar 10, 2020
Merged
Performance: remove legacy global edsClusters#21917istio-testing merged 6 commits intoistio:masterfrom
istio-testing merged 6 commits intoistio:masterfrom
Conversation
Member
Author
|
@howardjohn @ramaraochavali It is ready now |
esnible
approved these changes
Mar 9, 2020
Contributor
esnible
left a comment
There was a problem hiding this comment.
(I reviewed istioctl changes only)
Contributor
ramaraochavali
left a comment
There was a problem hiding this comment.
LGTM, one minor question. But definitely would like more eyes.
| continue | ||
| } | ||
|
|
||
| previous := sets.NewSet(con.Clusters...) |
Contributor
There was a problem hiding this comment.
I think sets was added just for this purpose - Do you want to retain them even if they are not used? I am OK to leave them like that as they could be used in else where in future.
Member
Author
|
@howardjohn Can we see the enhancement somewhere? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please provide a description for what this PR is for.
remove legacy
edsClustersto save cpu and memory.fix: #21913
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[x] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure