Skip to content

[Release-1.5] Update proxy/release1.5 sha in istio/release1.5#21237

Merged
istio-testing merged 12 commits intoistio:release-1.5from
gargnupur:nup_temp
Feb 19, 2020
Merged

[Release-1.5] Update proxy/release1.5 sha in istio/release1.5#21237
istio-testing merged 12 commits intoistio:release-1.5from
gargnupur:nup_temp

Conversation

@gargnupur
Copy link
Copy Markdown
Contributor

@gargnupur gargnupur commented Feb 19, 2020

No description provided.

@gargnupur gargnupur requested review from a team and yangminzhu February 19, 2020 00:26
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 19, 2020
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 19, 2020
@gargnupur gargnupur added do-not-merge Block automatic merging of a PR. do-not-merge/hold Block automatic merging of a PR. do-not-merge/post-submit do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. labels Feb 19, 2020
gargnupur and others added 7 commits February 18, 2020 17:03
)

* feat(grpc status codes): report grpc status codes via mixer

* response.grpc_status is a string

* force string instead of auto-detect duration

* update manifest files as well

* update to match istio/proxy PR

Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>

* update golden files

Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>

* add generated file

Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>

* running make gen a second time produces new results

Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 19, 2020
* Add TCP Stats and Metadata Filters for Istio 1.6

* Update Istio Proxy SHA

* Run make gen
…Test (istio#20818)

* Add TCP Stats and Metadata Filters for Istio 1.6

* Use Istio generated Metadata Exchange and Stats filters in TCP Stats test

* Run make gen
@gargnupur
Copy link
Copy Markdown
Contributor Author

/test pilot-multicluster-e2e_istio_release-1.5

@gargnupur gargnupur changed the title [Release-1.5] DO NOT MERGE Test PR Update proxy/release1.5 sha in istio/release1.5 Feb 19, 2020
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Feb 19, 2020
@gargnupur gargnupur removed do-not-merge Block automatic merging of a PR. do-not-merge/hold Block automatic merging of a PR. do-not-merge/post-submit labels Feb 19, 2020
@gargnupur gargnupur changed the title Update proxy/release1.5 sha in istio/release1.5 [Release-1.5] Update proxy/release1.5 sha in istio/release1.5 Feb 19, 2020
@gargnupur
Copy link
Copy Markdown
Contributor Author

/test e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.5

@gargnupur
Copy link
Copy Markdown
Contributor Author

/test integ-istioio-k8s-tests_istio_release-1.5

1 similar comment
@gargnupur
Copy link
Copy Markdown
Contributor Author

/test integ-istioio-k8s-tests_istio_release-1.5

Copy link
Copy Markdown
Contributor

@yangminzhu yangminzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@istio-testing istio-testing merged commit 50d937d into istio:release-1.5 Feb 19, 2020
@dgn
Copy link
Copy Markdown
Contributor

dgn commented Feb 24, 2020

Hi @gargnupur, since merging this the TestTcpMetric test has been broken in postsubmit (see https://prow.istio.io/view/gcs/istio-prow/logs/integ-k8s-115_istio_release-1.5_postsubmit/123). Could you take a look? Thank you

Note that we're running the postsubmits using the helm charts instead of istioctl

@gargnupur
Copy link
Copy Markdown
Contributor Author

@dgn: sure, taking a look.. although it's weird given it passed in presubmit...

@gargnupur
Copy link
Copy Markdown
Contributor Author

@dgn: Talked with @howardjohn about this and integ_k8s-115 use helm for install. I will disable this test when istioctl is not used..
I have to make an update to istio/istio proxy sha and will make fix to this test in that PR. Will update this once I have that fix.

@gargnupur gargnupur deleted the nup_temp branch October 8, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants