Support file mount to SDS migration#20511
Conversation
|
/cherrypick release-1.5 |
|
@howardjohn: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Looks like SdsUdsPath is still being used from mesh config - Should that also be taken from metadata?
There was a problem hiding this comment.
We don't have it in the metadata, so we don't really have a choice here since we cannot go back in time to old versions and add it - this is primarily about supporting upgrade from 1.4 -> 1.5. Should it have been done originally? probably. But I think now we have deprecated the mesh config field and will just use a hardcoded value
There was a problem hiding this comment.
I see. Makes sense.
sdake
left a comment
There was a problem hiding this comment.
lgtm from an env-wg perspective. Leave final review to networking team.
d25eeae to
90e0d63
Compare
|
/cherrypick release-1.5 |
|
@howardjohn: new pull request created: #20959 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Currently SDS is a global setting. In pilot-agent we configure metadata
to declare we are supporting SDS, but we ignore it in pilot. This checks
that metadata in Pilot. We also stop using "1" and use a proper bool.
Fixes #20497