Skip to content

operator/pkg/validate: fix dropped test error#20375

Merged
istio-testing merged 1 commit intoistio:masterfrom
alrs:fix-validate-dropped-err
Jan 21, 2020
Merged

operator/pkg/validate: fix dropped test error#20375
istio-testing merged 1 commit intoistio:masterfrom
alrs:fix-validate-dropped-err

Conversation

@alrs
Copy link
Copy Markdown
Contributor

@alrs alrs commented Jan 21, 2020

This picks up a recently-introduced dropped test error in operator/pkg/validate.

@alrs alrs requested a review from a team as a code owner January 21, 2020 19:15
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 21, 2020
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Jan 21, 2020
@istio-testing
Copy link
Copy Markdown
Collaborator

Hi @alrs. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn
Copy link
Copy Markdown
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jan 21, 2020
@istio-testing istio-testing merged commit 18965ce into istio:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test and release cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants