Closed
Conversation
Right now we end up placing it in GOPATH/out, but then we later reference it as ISTIO_ENVOY_LINUX_RELEASE_DIR which is pointing to istio.io/istio/out in the build container.
| do | ||
| FILTER_WASM_URL="${ISTIO_ENVOY_BASE_URL}/${plugin}-${ISTIO_ENVOY_VERSION}.wasm" | ||
| download_wasm_if_necessary "${FILTER_WASM_URL}" "${WASM_RELEASE_DIR}"/"${plugin//_/-}"-filter.wasm | ||
| cp -f "${WASM_RELEASE_DIR}"/"${plugin//_/-}"-filter.wasm "${ISTIO_OUT}"/"${plugin//_/-}"-filter.wasm |
Contributor
There was a problem hiding this comment.
So this change is going to copy these files from istio.io/istio/out/linux_amd64/release to istio.io/istio/out/linux_amd64? Why? The proxy make file reference $ISTIO_ENVOY_LINUX_RELEASE_DIR which is istio.io/istio/out/linux_amd64/release.
Member
Author
There was a problem hiding this comment.
Hm maybe this isn't quite right. Something is not working for me, but this doesn't seem like the right fix. I'll play around with it some more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now we end up placing it in GOPATH/out, but then we later
reference it as ISTIO_ENVOY_LINUX_RELEASE_DIR which is pointing to
istio.io/istio/out in the build container.