Skip to content

install: Always add POD_NAMESPACE var, even if env is unset#20349

Merged
istio-testing merged 1 commit intoistio:masterfrom
dgn:dgn/policy-deployment-fix
Jan 21, 2020
Merged

install: Always add POD_NAMESPACE var, even if env is unset#20349
istio-testing merged 1 commit intoistio:masterfrom
dgn:dgn/policy-deployment-fix

Conversation

@dgn
Copy link
Copy Markdown
Contributor

@dgn dgn commented Jan 21, 2020

In cases when no env variable is set, we wouldn't set POD_NAMESPACE in the policy deployment (for the telemetry deployment this has been fixed earlier already)

[x] Installation

@dgn dgn requested a review from a team as a code owner January 21, 2020 09:08
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 21, 2020
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 21, 2020
@dgn
Copy link
Copy Markdown
Contributor Author

dgn commented Jan 21, 2020

/retest

Copy link
Copy Markdown
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@istio-testing istio-testing merged commit 4466c2d into istio:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/environments cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants