Skip to content

Update operator --set help text #20204#20342

Merged
istio-testing merged 8 commits intoistio:masterfrom
blhagadorn:master
Jan 21, 2020
Merged

Update operator --set help text #20204#20342
istio-testing merged 8 commits intoistio:masterfrom
blhagadorn:master

Conversation

@blhagadorn
Copy link
Copy Markdown
Contributor

@blhagadorn blhagadorn commented Jan 20, 2020 •
edited by istio-policy-bot
Loading

This is a repeat of #20204 without all of the commits I didn't make addresses issue #19999 and functionally chages the Help string as well as adds Example: to cobraCommands.

[ ] Configuration Infrastructure
[ x] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ x] User Experience
[ ] Developer Infrastructure

@blhagadorn blhagadorn requested a review from a team as a code owner January 20, 2020 23:36
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 20, 2020
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 20, 2020
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jan 20, 2020

Hi @blhagadorn. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

howardjohn
howardjohn reviewed Jan 20, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

/ok-to-test

operator/cmd/mesh/manifest-apply.go
Example: "istioctl manifest apply # installs the default profile on the current Kubernetes cluster context\n" +
"istioctl manifest apply --set values.global.mtls.enabled=true --set values.global.controlPlaneSecurityEnabled=true\n" +
"istioctl manifest apply --set profile=demo\n" +
"istioctl manifest apply --set installPackagePath=~/istio-releases/istio-1.4.3/install/kubernetes/operator/charts",
Copy link
Copy Markdown
Member

@howardjohn howardjohn Jan 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ostromart I didn't think we expand ~, am I wrong?

Copy link
Copy Markdown
Contributor Author

@blhagadorn blhagadorn Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took that from this, https://istio.io/docs/setup/install/istioctl/#install-from-external-charts, happy to alter it and throw in an absolute directory (and update istio.io).

operator/cmd/mesh/root.go Outdated
Overrides the corresponding path value in the selected profile or passed through IstioOperator CR
customization file`
SetFlagHelpStr = `Override an IstioOperator value, e.g. to choose a profile
(--set profile=demo), enable or disable components (--set policy.enabled=true), or override Istio
Copy link
Copy Markdown
Member

@howardjohn howardjohn Jan 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is -- components.policy.enabled=true now?

Copy link
Copy Markdown
Contributor Author

@blhagadorn blhagadorn Jan 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you're right, good catch. Changed. For reference:

istio/operator/data/profiles/default.yaml

Lines 56 to 58 in 07dedc3

policy:
enabled: false
k8s:

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jan 20, 2020
blhagadorn and others added 2 commits January 20, 2020 22:14
@blhagadorn @howardjohn
Update operator/cmd/mesh/root.go
5fc527c 
Formatting

Co-Authored-By: John Howard <howardjohn@google.com>
@blhagadorn
Update root.go
6e2412e
@istio-testing istio-testing merged commit 1480ad0 into istio:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees

No one assigned

Labels

area/user experience cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@blhagadorn @istio-testing @howardjohn @googlebot @istio-policy-bot