Skip to content

Add more SDS tests and improve error handling.#20341

Merged
istio-testing merged 4 commits intoistio:masterfrom
myidpt:sdstesting3
Jan 22, 2020
Merged

Add more SDS tests and improve error handling.#20341
istio-testing merged 4 commits intoistio:masterfrom
myidpt:sdstesting3

Conversation

@myidpt
Copy link
Copy Markdown

@myidpt myidpt commented Jan 20, 2020

Added:

  • Tests on node agent with mocked Google CA and STS server.

Fixed:

  • SDS service will directly reject the request if the authorization header has an empty value, instead of forwarding it to STS server.

Improved:

  • Logging message on secretcache.

@myidpt myidpt requested a review from JimmyCYJ January 20, 2020 23:28
@myidpt myidpt requested a review from a team as a code owner January 20, 2020 23:28
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 20, 2020
@istio-testing istio-testing added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 20, 2020
@myidpt myidpt changed the title Improve SDS / nodeagent testing and error handling. Improve SDS testing and error handling. Jan 21, 2020
@myidpt myidpt changed the title Improve SDS testing and error handling. Add more SDS tests and improve error handling. Jan 21, 2020
@istio-testing istio-testing merged commit 77e1e9b into istio:master Jan 22, 2020
@myidpt myidpt deleted the sdstesting3 branch January 22, 2020 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants