Stopgap for Galley dashboards with istiod#20302
Merged
istio-testing merged 2 commits intoistio:masterfrom Jan 19, 2020
Merged
Conversation
Right now on Istiod the galley dashboard is not useful because there is no galley. In the 1.5 timeframe it may not be feasible to refactor our dashboards to be feature oriented rather than component (if we even desire this). In the short term, we can make all of the metrics shared between istiod and galley not have a job= label. This will allow it to pick up either source of the metric. We cannot do this for the other metrics, as they are generic like CPU, etc.
ayj
approved these changes
Jan 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now on Istiod the galley dashboard is not useful because there is
no galley. In the 1.5 timeframe it may not be feasible to refactor our
dashboards to be feature oriented rather than component (if we even
desire this). In the short term, we can make all of the metrics shared
between istiod and galley not have a job= label. This will allow it to
pick up either source of the metric. We cannot do this for the other
metrics, as they are generic like CPU, etc.