Skip to content

Prune renamed components#20288

Merged
istio-testing merged 1 commit intoistio:masterfrom
elfinhe:prune-renamed-components
Jan 18, 2020
Merged

Prune renamed components#20288
istio-testing merged 1 commit intoistio:masterfrom
elfinhe:prune-renamed-components

Conversation

@elfinhe
Copy link
Copy Markdown
Member

@elfinhe elfinhe commented Jan 18, 2020 •
edited
Loading

Prune renamed and merged-into-pilot components.
Alternatives considered.

  1. Change back the name to Inject in operator/api, since this component is going away eventually - protobuf gen does not allow me to do it. Instead we need to reserve SIdecarInjector and add Injector back.
  2. Using label flag -l 'operator.istio.io/component in (Injector, SidecarInjector)' to prune - not working with kubectl, i.e., cannot prune deploy and service.

So I add deprecated component manifest:

istioctldev manifest apply  -f ~/default.yaml 
- Applying manifest for component Base...
- Pruning objects for disabled component Injector...
✔ Finished pruning objects for disabled component Injector.
- Applying manifest for component SidecarInjector...
- Applying manifest for component Citadel...
- Applying manifest for component Galley...
- Applying manifest for component Addon...
- Applying manifest for component Policy...
- Applying manifest for component IngressGateways...
- Applying manifest for component Pilot...
- Applying manifest for component Telemetry...
✔ Finished applying manifest for component SidecarInjector.
✔ Finished applying manifest for component Citadel.
✔ Finished applying manifest for component Addon.
✔ Finished applying manifest for component Galley.
✔ Finished applying manifest for component IngressGateways.
✔ Finished applying manifest for component Policy.
✔ Finished applying manifest for component Pilot.
✔ Finished applying manifest for component Telemetry.

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jan 18, 2020
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 18, 2020
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 18, 2020
@elfinhe elfinhe marked this pull request as ready for review January 18, 2020 01:07
@elfinhe elfinhe requested a review from a team as a code owner January 18, 2020 01:07
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jan 18, 2020
@elfinhe
Copy link
Copy Markdown
Member Author

elfinhe commented Jan 18, 2020

/retest

@istio-testing istio-testing merged commit f69e8a1 into istio:master Jan 18, 2020
@howardjohn howardjohn mentioned this pull request Jan 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees

No one assigned

Labels

area/environments cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@elfinhe @howardjohn @googlebot @istio-testing @istio-policy-bot