Skip to content

Remove certmanager integration#20269

Merged
istio-testing merged 2 commits intoistio:masterfrom
howardjohn:manifests/remove-certmanager-integration
Jan 18, 2020
Merged

Remove certmanager integration#20269
istio-testing merged 2 commits intoistio:masterfrom
howardjohn:manifests/remove-certmanager-integration

Conversation

@howardjohn
Copy link
Copy Markdown
Member

@howardjohn howardjohn commented Jan 17, 2020

This has been deprecated and removed from all docs for the past 2
releases. It is untested and does not work anymore (due to deprecation
of this version of certmanager).

@howardjohn howardjohn requested a review from a team as a code owner January 17, 2020 18:17
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 17, 2020
@istio-testing istio-testing added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 17, 2020
Copy link
Copy Markdown
Member

@elfinhe elfinhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

btw, it is also included in #20252

@howardjohn howardjohn added do-not-merge/hold Block automatic merging of a PR. and removed do-not-merge/hold Block automatic merging of a PR. labels Jan 17, 2020
@howardjohn
Copy link
Copy Markdown
Member Author

/retest

This has been deprecated and removed from all docs for the past 2
releases. It is untested and does not work anymore (due to deprecation
of this version of certmanager).
@howardjohn howardjohn force-pushed the manifests/remove-certmanager-integration branch from f93de92 to 472e644 Compare January 17, 2020 23:50
@howardjohn
Copy link
Copy Markdown
Member Author

/retest

@istio-testing istio-testing merged commit 925ae69 into istio:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants