remove the ability for pilot to register CRDs itself#20085
Merged
istio-testing merged 5 commits intoistio:masterfrom Jan 21, 2020
Merged
remove the ability for pilot to register CRDs itself#20085istio-testing merged 5 commits intoistio:masterfrom
istio-testing merged 5 commits intoistio:masterfrom
Conversation
Installing and modifying CRDs requires elevated cluster-wide permissions. This should be done by a separate install step (istio-init) or by an operator.
howardjohn
reviewed
Jan 10, 2020
| resources: ["*"] | ||
| verbs: ["*"] | ||
| - apiGroups: ["apiextensions.k8s.io"] | ||
| resources: ["customresourcedefinitions"] |
Member
There was a problem hiding this comment.
do we not need get for anything? I don't think we do but just checking
Contributor
Author
There was a problem hiding this comment.
Pilot doesn't. Istiod will eventually need this when Galley's processing pipeline is enabled.
…pilot-crd-install-option
Contributor
Author
|
/hold until #19985 is merged |
…pilot-crd-install-option
Member
|
/retest |
Contributor
Author
|
The controller_test.go is depending on the mock type being created. Fix pending. |
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing and modifying CRDs requires elevated cluster-wide
permissions. This should be done by a separate install step
(istio-init) or by an operator.