Skip to content

[test] Add test for Health Checking of Istio Services#20068

Merged
istio-testing merged 5 commits intoistio:masterfrom
shamsher31:health-check
Jan 20, 2020
Merged

[test] Add test for Health Checking of Istio Services#20068
istio-testing merged 5 commits intoistio:masterfrom
shamsher31:health-check

Conversation

@shamsher31
Copy link
Copy Markdown
Member

@shamsher31 shamsher31 commented Jan 10, 2020 •
edited by istio-policy-bot
Loading

To fix #19953

@shamsher31 shamsher31 requested review from a team as code owners January 10, 2020 13:24
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 10, 2020
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test labels Jan 10, 2020
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jan 10, 2020

Hi @shamsher31. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shamsher31 shamsher31 changed the title #19953 Add test for Health Checking of Istio Services [test] Add test for Health Checking of Istio Services Jan 10, 2020
dgn
dgn reviewed Jan 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@dgn dgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should get rid of the sleeps, other than that it's looking good

shamsher31
shamsher31 commented Jan 13, 2020
View reviewed changes
Copy link
Copy Markdown
Member Author

@shamsher31 shamsher31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary sleep from all test.

@dgn
Copy link
Copy Markdown
Contributor

dgn commented Jan 14, 2020

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jan 14, 2020
dgn
dgn approved these changes Jan 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@dgn dgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, just one minor issue

@brian-avery
Copy link
Copy Markdown
Member

brian-avery commented Jan 14, 2020

/retest

@brian-avery
Copy link
Copy Markdown
Member

brian-avery commented Jan 15, 2020

Thanks! Looks good to me other than a couple of minor things.

@shamsher31 shamsher31 mentioned this pull request Jan 20, 2020
Merged
shamsher31
shamsher31 commented Jan 20, 2020
View reviewed changes
Copy link
Copy Markdown
Member Author

@shamsher31 shamsher31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated namespace change on istio.io docs

@istio-testing istio-testing merged commit e919c0a into istio:master Jan 20, 2020
@shamsher31 shamsher31 deleted the health-check branch January 21, 2020 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgn dgn dgn approved these changes

+1 more reviewer

@brian-avery brian-avery brian-avery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/test and release cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[istio.io testing] Need test for Health Checking of Istio Services

6 participants

@shamsher31 @istio-testing @dgn @brian-avery @googlebot @istio-policy-bot