Skip to content

re-add kubeconfig to the create_release_archive script. Required for…#1998

Merged
istio-merge-robot merged 1 commit intoistio:masterfrom
GregHanson:kubeconfig-fix
Dec 6, 2017
Merged

re-add kubeconfig to the create_release_archive script. Required for…#1998
istio-merge-robot merged 1 commit intoistio:masterfrom
GregHanson:kubeconfig-fix

Conversation

@GregHanson
Copy link
Copy Markdown
Member

@GregHanson GregHanson commented Dec 6, 2017

… consul and Eurkea demos

What this PR does / why we need it:
kubeconfig was not added to the find and so the kubeconfig file in install/consul and install/eureka is not getting added to the release.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Issue #1995

Special notes for your reviewer:

Release note:

NONE

@istio-testing
Copy link
Copy Markdown
Collaborator

@GregHanson: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

Details

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andraxylia
Copy link
Copy Markdown
Contributor

/lgtm

@istio-merge-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andraxylia

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link
Copy Markdown

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link
Copy Markdown

Automatic merge from submit-queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants