Improve SDS logging for consistency#19865
Merged
istio-testing merged 1 commit intoistio:masterfrom Dec 31, 2019
Merged
Conversation
Currently SDS logging is inconsistant with Pilot/pilot-agent. This was not as noticable before, but now that they are in the same deployment its very noticeable and makes parsing the logs harder. This change is a step towards consistency with the rest of Istio and reduces the verbosity substantially.
myidpt
approved these changes
Dec 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently SDS logging is inconsistant with Pilot/pilot-agent. This was
not as noticable before, but now that they are in the same deployment
its very noticeable and makes parsing the logs harder.
This change is a step towards consistency with the rest of Istio and
reduces the verbosity substantially.