Apa Template bootstrap codegen.#1960
Conversation
|
@guptasu: Adding do-not-merge/release-note-label-needed because the release note process has not been followed. DetailsOne of the following labels is required "release-note", "release-note-action-required", or "release-note-none". Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1960 +/- ##
=========================================
- Coverage 81.81% 79.72% -2.1%
=========================================
Files 190 70 -120
Lines 15675 6731 -8944
=========================================
- Hits 12825 5366 -7459
+ Misses 2414 1088 -1326
+ Partials 436 277 -159
Continue to review full report at Codecov.
|
|
@geeknoid @douglas-reid @mandarjog @ozevren friendly ping. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/retest |
|
/test all |
|
bazel vs go toolchain issue. This seems to happen for quite a few PRs that introduce new functionality that uses auto-generated files. + go test -coverprofile=/tmp/coverage/istio.io-istio-mixer-template-sample-quota.txt istio.io/istio/mixer/template/sample/quota
# istio.io/istio/mixer/template/sample
mixer/template/sample/template.gen_test.go:39:2: no Go files in /go/src/istio.io/istio/mixer/template/sample/apa
FAIL istio.io/istio/mixer/template/sample [setup failed]Generated files are not present in package directory which is then imported. Import of package with no Go files is an error. |
|
Is go test required ? Bazel test is the only required build system for now,
afaik. Go test only executes within circleci and circleci is not required.
…On Dec 5, 2017 12:04 AM, "Etai Lev Ran" ***@***.***> wrote:
bazel vs go toolchain issue. This seems to happen for quite a few PRs that
introduce new functionality that uses auto-generated files.
+ go test -coverprofile=/tmp/coverage/istio.io-istio-mixer-template-sample-quota.txt istio.io/istio/mixer/template/sample/quota# istio.io/istio/mixer/template/sample
mixer/template/sample/template.gen_test.go:39:2: no Go files in /go/src/istio.io/istio/mixer/template/sample/apa
FAIL istio.io/istio/mixer/template/sample [setup failed]
Generated files are not present in package directory which is then
imported. Import of package with no Go files is an error.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1960 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AK6xEx0_zGVBhjISYQzhyiglVGag8F6Kks5s9PkggaJpZM4Qy3gF>
.
|
It does the generation of instances that are dispatched to APA adapters and also generates new attributes from the response of the adapter. This PR finishes the APA support in Mixer. Next: - Change the Kubernetes adapter to use the new model. - Finally cleanup the old model.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geeknoid The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
@guptasu Note that |
What this PR does / why we need it:
It does the generation of instances that are dispatched to APA adapters
and also generates new attributes from the response of the adapter.
This PR finishes the APA support in Mixer.
Next:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: