Graduate istioctl analyze out of experimental#19488
Merged
istio-testing merged 5 commits intoistio:masterfrom Dec 10, 2019
Merged
Graduate istioctl analyze out of experimental#19488istio-testing merged 5 commits intoistio:masterfrom
istio-testing merged 5 commits intoistio:masterfrom
Conversation
a0b8a11 to
e2c0ec4
Compare
Member
I was going to recommend this. Especially for something intended for CI use, arbitrarily changing the command is annoying. |
Contributor
Author
|
/test pilot-multicluster-e2e_istio |
Contributor
Author
Contributor
|
I like this approach. One comment on wording, otherwise lgtm. |
ayj
reviewed
Dec 10, 2019
ayj
approved these changes
Dec 10, 2019
Contributor
Author
|
/test unit-tests_istio |
This was referenced Dec 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Graduate
istioctl analyzeout of experimental for 1.5.This PR proposes doing this as a "soft" graduation, where
istioctl analyzebecomes canonical butistioctl experimental analyzecontinues to work, but includes a run-time notice encouraging users to switch. The same message is also present in usage messages. Doing it this way, you'd naturally expect to make it a hard graduation in 1.6, then remove the experimental command in 1.7. I'm interested in feedback on whether this is a desirable approach, or if it just makes the migration ramp unnecessarily long.Also updated the usage for
istioctl validateto more strongly indicate that users should move toistioctl analyze.This also includes a fix to
getDefaultNamespacefor istioctl, so that it correctly respects the--contextoption.See #16777
Some examples below to demonstrate how the soft graduation looks: