Skip to content

err is definded before#19461

Merged
istio-testing merged 1 commit intoistio:masterfrom
helight:dev-helight
Dec 8, 2019
Merged

err is definded before#19461
istio-testing merged 1 commit intoistio:masterfrom
helight:dev-helight

Conversation

@helight
Copy link
Copy Markdown
Member

@helight helight commented Dec 8, 2019

No description provided.

@helight helight requested a review from a team December 8, 2019 15:51
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Dec 8, 2019
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Dec 8, 2019
@istio-testing
Copy link
Copy Markdown
Collaborator

Hi @helight. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Contributor

@mandarjog mandarjog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mandarjog
Copy link
Copy Markdown
Contributor

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Dec 8, 2019
@istio-testing istio-testing merged commit 7fa4b09 into istio:master Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/extensions and telemetry cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants