Do not generate CRD for SSE#19448
Merged
istio-testing merged 1 commit intoistio:masterfrom Dec 10, 2019
Merged
Conversation
Member
Author
|
@hzxuzhonghu & @howardjohn PTAL |
Member
Author
|
/test unit-tests_istio |
hzxuzhonghu
approved these changes
Dec 7, 2019
howardjohn
reviewed
Dec 7, 2019
Member
howardjohn
left a comment
There was a problem hiding this comment.
Can we just remove it from the schema.yaml or is that used in other places?
Member
Author
@howardjohn it is being used in a lot of places and for consistency I think it's best to keep it in the schemas but not in the knownTypes because that's what crd controller uses to generate the CRDs. |
rshriram
approved these changes
Dec 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do not want to generate CRD for SyntheticServiceEntry and this change is to excluede SyntheticSericeEntries from Istio Schemas since that's what we use in crd controller to generate CRDs.
Related issue: #19286