Skip to content

switch latest to 0.3.0#1940

Merged
ldemailly merged 1 commit intomasterfrom
ldemailly-0-3-0
Dec 11, 2017
Merged

switch latest to 0.3.0#1940
ldemailly merged 1 commit intomasterfrom
ldemailly-0-3-0

Conversation

@ldemailly
Copy link
Copy Markdown
Member

@ldemailly ldemailly commented Nov 30, 2017

ps: shouldn't this be part of finalize

NONE

@istio-testing
Copy link
Copy Markdown
Collaborator

@ldemailly: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

Details

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rkpagadala
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@istio-merge-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rkpagadala
We suggest the following additional approver: ldemailly

Assign the PR to them by writing /assign @ldemailly in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@ldemailly ldemailly added the do-not-merge Block automatic merging of a PR. label Nov 30, 2017
@ldemailly
Copy link
Copy Markdown
Member Author

there is debate on holding off on changing this pending kubecon demos etc
(even though curl -L https://git.io/getIstio | sh would still be 0.2.12 either way)

@douglas-reid
Copy link
Copy Markdown
Contributor

I think postponing this a week, especially given that everyone will be on travel, etc., makes sense, even if there is a workaround.

Should we target Dec 6 (after istio summit / workshop) or Dec 9 (after kubecon)?

@mattdelco
Copy link
Copy Markdown
Contributor

Updating the revision was an oversight and normally done as part of a release. The eventual direction is probably to move towards cutting down on the # of files that need to get updated, possibly by grabbing the version # from another location or leveraging the result of https://api.github.com/repos/istio/istio/releases/latest

@linsun
Copy link
Copy Markdown
Member

linsun commented Dec 1, 2017

Folks, please hold off this until it is well tested. I won't have time to do a personal spin on this till after kubecon. We have a lab coming up and many interest in istio next week, we would want everyone use the most stable release.

Copy link
Copy Markdown
Member

@linsun linsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment earlier, need more time.

@ldemailly
Copy link
Copy Markdown
Member Author

@linsun can this (or #1977) go in now ? kubecon is over ?

@christian-posta
Copy link
Copy Markdown
Contributor

christian-posta commented Dec 8, 2017 via email

Copy link
Copy Markdown
Member

@linsun linsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick testing on IBM Cloud Container Service (k8s 1.7.4) it works at the first glance. Thank you for holding the move for kubecon, appreciate that!

@ldemailly ldemailly removed the do-not-merge Block automatic merging of a PR. label Dec 11, 2017
@ldemailly ldemailly merged commit 810b462 into master Dec 11, 2017
@ldemailly ldemailly deleted the ldemailly-0-3-0 branch December 11, 2017 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants