Skip to content

feat(bootstrap): add support for AWS platform to bootstrap#19205

Merged
istio-testing merged 2 commits intoistio:masterfrom
douglas-reid:add-aws-bootstrap-support
Dec 9, 2019
Merged

feat(bootstrap): add support for AWS platform to bootstrap#19205
istio-testing merged 2 commits intoistio:masterfrom
douglas-reid:add-aws-bootstrap-support

Conversation

@douglas-reid
Copy link
Copy Markdown
Contributor

@douglas-reid douglas-reid commented Nov 25, 2019 •
edited by istio-policy-bot
Loading

This PR expands the set of platforms considered as part of the bootstrap configuration process to include AWS. This will enable the population of the AWS EC2 metadata for Envoy nodes running on EC2 instances in the Envoy node metadata.

Signed-off-by: Douglas Reid douglas-reid@users.noreply.github.com

@douglas-reid
feat(bootstrap): add support for AWS platform to bootstrap
a5b6202 
Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
@douglas-reid douglas-reid requested a review from a team as a code owner November 25, 2019 22:01
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 25, 2019
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 25, 2019
@douglas-reid
Copy link
Copy Markdown
Contributor Author

douglas-reid commented Nov 26, 2019

Validated on an EKS cluster:

     "PLATFORM_METADATA": {
       "aws_region": "us-west-2",
       "aws_account_id": "***********4",
       "aws_instance_id": "i-***********bee4c0",
       "aws_availability_zone": "us-west-2c"
      },
...
     "locality": {
      "region": "us-west-2",
      "zone": "us-west-2c"
     },

@douglas-reid
Copy link
Copy Markdown
Contributor Author

douglas-reid commented Nov 26, 2019

/test pilot-multicluster-e2e_istio

@douglas-reid
Copy link
Copy Markdown
Contributor Author

douglas-reid commented Dec 5, 2019

Ping for review.

rshriram
rshriram approved these changes Dec 5, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@rshriram rshriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

howardjohn
howardjohn reviewed Dec 6, 2019
View reviewed changes
pkg/bootstrap/platform/platform.go Outdated
Locality() *core.Locality
}

// Unknown provides a default platform environment for cases in wich the platform
Copy link
Copy Markdown
Member

@howardjohn howardjohn Dec 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Unknown provides a default platform environment for cases in wich the platform
// Unknown provides a default platform environment for cases in which the platform

@douglas-reid
Copy link
Copy Markdown
Contributor Author

douglas-reid commented Dec 9, 2019

/test unit-tests_istio

flake

@istio-testing istio-testing merged commit ff1a39d into istio:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@howardjohn howardjohn howardjohn approved these changes

@mandarjog mandarjog Awaiting requested review from mandarjog

+1 more reviewer

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/environments area/extensions and telemetry area/networking cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@douglas-reid @howardjohn @rshriram @googlebot @istio-testing @istio-policy-bot