Skip to content

rm Gopkg.lock#1910

Merged
rshriram merged 4 commits intomasterfrom
urgent_fix
Nov 29, 2017
Merged

rm Gopkg.lock#1910
rshriram merged 4 commits intomasterfrom
urgent_fix

Conversation

@rshriram
Copy link
Copy Markdown
Member

@rshriram rshriram commented Nov 29, 2017

We no longer need this file. Also gitignored.

@rshriram rshriram requested review from ZackButcher and jmuk November 29, 2017 03:50
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Nov 29, 2017

@rshriram: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

Details

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 29, 2017 •
edited
Loading

Codecov Report

Merging #1910 into master will decrease coverage by 0.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1910      +/-   ##
==========================================
- Coverage   81.72%   81.16%   -0.57%     
==========================================
  Files         202      186      -16     
  Lines       20472    18883    -1589     
==========================================
- Hits        16731    15326    -1405     
+ Misses       3271     3126     -145     
+ Partials      470      431      -39
Flag Coverage Δ
#broker 44.44% <ø> (-1.07%) ⬇️
#mixer 82.42% <ø> (-0.81%) ⬇️
#pilot 80.4% <ø> (-0.11%) ⬇️
#security 90.39% <ø> (ø) ⬆️
Impacted Files Coverage Δ
mixer/adapter/prometheus/server.go 89.83% <0%> (-5.09%) ⬇️
mixer/adapter/stackdriver/metric/bufferedClient.go 90% <0%> (-2.5%) ⬇️
mixer/pkg/config/crd/store.go 96.36% <0%> (-0.61%) ⬇️
mixer/pkg/runtime/init.go
pilot/platform/kube/inject/http.go
mixer/pkg/runtime/monitor.go
mixer/pkg/runtime/controller.go
broker/pkg/version/version.go
pilot/platform/kube/inject/initializer.go
mixer/pkg/runtime/env.go
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab76cee...c179f02. Read the comment docs.

@vadimeisenbergibm vadimeisenbergibm self-requested a review November 29, 2017 04:49
@vadimeisenbergibm
Copy link
Copy Markdown
Contributor

vadimeisenbergibm commented Nov 29, 2017

/lgtm

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Nov 29, 2017

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vadimeisenbergibm
We suggest the following additional approver: andraxylia

Assign the PR to them by writing /assign @andraxylia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

vadimeisenbergibm
vadimeisenbergibm approved these changes Nov 29, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@vadimeisenbergibm vadimeisenbergibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rshriram rshriram merged commit a8cf3ca into master Nov 29, 2017
@rshriram rshriram deleted the urgent_fix branch January 3, 2018 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmuk jmuk Awaiting requested review from jmuk

@ZackButcher ZackButcher Awaiting requested review from ZackButcher

1 more reviewer

@vadimeisenbergibm vadimeisenbergibm vadimeisenbergibm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vadimeisenbergibm vadimeisenbergibm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rshriram @istio-testing @vadimeisenbergibm @istio-merge-robot @googlebot