Skip to content

fix synchronization of codegen files#1908

Merged
rshriram merged 1 commit intoistio:masterfrom
jmuk:bazel_to_go
Nov 29, 2017
Merged

fix synchronization of codegen files#1908
rshriram merged 1 commit intoistio:masterfrom
jmuk:bazel_to_go

Conversation

@jmuk
Copy link
Copy Markdown
Contributor

@jmuk jmuk commented Nov 29, 2017

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Nov 29, 2017

@jmuk: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

Details

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmuk
Copy link
Copy Markdown
Contributor Author

jmuk commented Nov 29, 2017

/release-note-none

@jmuk
Copy link
Copy Markdown
Contributor Author

jmuk commented Nov 29, 2017

/assign @ayj

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Nov 29, 2017

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: geeknoid

Assign the PR to them by writing /assign @geeknoid in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 29, 2017 •
edited
Loading

Codecov Report

Merging #1908 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1908      +/-   ##
==========================================
- Coverage   81.22%   81.19%   -0.04%     
==========================================
  Files         191      189       -2     
  Lines       19455    19405      -50     
==========================================
- Hits        15803    15755      -48     
+ Misses       3192     3190       -2     
  Partials      460      460
Flag Coverage Δ
#broker 44.44% <ø> (-1.07%) ⬇️
#mixer 82.44% <ø> (-0.02%) ⬇️
#pilot 80.5% <ø> (-0.06%) ⬇️
#security 90.39% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pilot/platform/kube/queue.go 82.69% <0%> (-7.7%) ⬇️
mixer/pkg/mock/server.go
broker/pkg/version/version.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d10410a...4d50bd2. Read the comment docs.

@rshriram rshriram merged commit 2df5407 into istio:master Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ayj ayj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jmuk @istio-testing @istio-merge-robot @rshriram @ayj @googlebot