dep ensure on cache miss in circleci#1903
Conversation
|
@rshriram: Adding do-not-merge/release-note-label-needed because the release note process has not been followed. DetailsOne of the following labels is required "release-note", "release-note-action-required", or "release-note-none". Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1903 +/- ##
==========================================
- Coverage 81.2% 81.16% -0.05%
==========================================
Files 191 190 -1
Lines 19455 18307 -1148
==========================================
- Hits 15799 14859 -940
+ Misses 3194 3051 -143
+ Partials 462 397 -65
Continue to review full report at Codecov.
|
|
/test istio-presubmit |
|
What happens if we remove it from the lock file? I see why it was floated to semver master. |
|
what do you mean? We only care about the versions of specific dependencies in gopkg.toml.. So I make circleci cache key off gopkg.toml only.. |
|
@costinm @andraxylia Unpinning istio/api from Gopkg.toml makes it inconsistent with bazel, so making lock file pin makes sense. Is there a reason why you tolerate this divergence from bazel? |
|
I am not unpinning anything. I have pinned it to a specific version in toml |
|
Thanks. I've objected to irreproducible master pin in the previous change. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyessenov The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/release-note-none |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Pin Istio/api and istio/fortio to particular SHAs in Gopkg.toml. Otherwise, builds in circleci will continue using old cached version of Gopkg.lock, which will prevent people from updating istio/api and applying the updates here.