Skip to content

Fix population of version information#1902

Merged
istio-merge-robot merged 12 commits intoistio:masterfrom
mattdelco:master2
Nov 29, 2017
Merged

Fix population of version information#1902
istio-merge-robot merged 12 commits intoistio:masterfrom
mattdelco:master2

Conversation

@mattdelco
Copy link
Copy Markdown
Contributor

@mattdelco mattdelco commented Nov 28, 2017

Bazel only wants to look at tools/bazel.rc, but monorepo didn't move the indvidual repo's files to istio/tools/bazel.rc (which also requires unifying the differences in the files). Additionally, the linkstamp references weren't updated to the new library paths used in post-monorepo.

Without this change the version info in "istioctl version" was empty (besides go verison), and after this change the version info is populated.

I also removed files that were only used by cloud builder in 0.2. I thought these were already deleted to either I overlooked them or someone added them back.

NONE

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 28, 2017 •
edited
Loading

Codecov Report

Merging #1902 into master will increase coverage by 0.47%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1902      +/-   ##
==========================================
+ Coverage    81.2%   81.68%   +0.47%     
==========================================
  Files         191      204      +13     
  Lines       19455    20602    +1147     
==========================================
+ Hits        15799    16828    +1029     
- Misses       3194     3294     +100     
- Partials      462      480      +18
Flag Coverage Δ
#broker 44.44% <ø> (-1.07%) ⬇️
#mixer 83.21% <ø> (+0.75%) ⬆️
#pilot 80.44% <ø> (-0.07%) ⬇️
#security 86.65% <100%> (-3.74%) ⬇️
Impacted Files Coverage Δ
security/cmd/istio_ca/version/version.go 100% <100%> (ø) ⬆️
broker/pkg/version/version.go
pilot/tools/version/version.go
mixer/pkg/runtime/logger.go 100% <0%> (ø)
mixer/pkg/runtime/resolver.go 93.38% <0%> (ø)
mixer/pkg/runtime/dispatcher.go 96.69% <0%> (ø)
security/pkg/platform/client.go 100% <0%> (ø)
mixer/pkg/runtime/context.go 100% <0%> (ø)
mixer/pkg/runtime/init.go 28.33% <0%> (ø)
security/pkg/platform/onprem.go 84.74% <0%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d7d57...e7b98d3. Read the comment docs.

@mattdelco mattdelco mentioned this pull request Nov 28, 2017
Closed
@mattdelco mattdelco changed the title Fix population of version informaion Fix population of version information Nov 28, 2017
@rkpagadala
Copy link
Copy Markdown
Contributor

rkpagadala commented Nov 28, 2017

/lgtm

@mattdelco
Copy link
Copy Markdown
Contributor Author

mattdelco commented Nov 28, 2017 •
edited by yutongz
Loading

/assign @geeknoid
/assign @guptasu

@mattdelco mattdelco mentioned this pull request Nov 28, 2017
Closed
@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Nov 28, 2017

/lgtm cancel //PR changed after LGTM, removing LGTM. @geeknoid @guptasu @mattdelco @rkpagadala

@geeknoid
Copy link
Copy Markdown
Contributor

geeknoid commented Nov 29, 2017

/approve

@mattdelco
Copy link
Copy Markdown
Contributor Author

mattdelco commented Nov 29, 2017

/retest

@mattdelco
Copy link
Copy Markdown
Contributor Author

mattdelco commented Nov 29, 2017

/retest

@hklai
Copy link
Copy Markdown
Contributor

hklai commented Nov 29, 2017

/lgtm

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Nov 29, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geeknoid, hklai, rkpagadala

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Nov 29, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Nov 29, 2017

Automatic merge from submit-queue.

@istio-merge-robot istio-merge-robot merged commit fb8bff0 into istio:master Nov 29, 2017
@mattdelco mattdelco deleted the master2 branch November 29, 2017 07:05
@Maamar Maamar mentioned this pull request Oct 5, 2022
Open
@vinodkumar4b9 vinodkumar4b9 mentioned this pull request Oct 5, 2022
Open
@rkamisetti792 rkamisetti792 mentioned this pull request Oct 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sebastienvas sebastienvas sebastienvas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rkpagadala rkpagadala

@guptasu guptasu

@geeknoid geeknoid

@hklai hklai

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@mattdelco @rkpagadala @istio-merge-robot @geeknoid @hklai @sebastienvas @googlebot @guptasu @istio-testing