[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: mandarjog

Assign the PR to them by writing /assign @mandarjog in a comment when ready.

The full list of commands accepted by this bot can be found here.

/retest

Not at all clear to me why prow presubmit is failing - it logs that the build failed, but I can't find any indication of failure from bazel in the logs it produces (and I can't repro locally).

Codecov Report

Merging #1898 into master will increase coverage by 0.54%.
The diff coverage is 96.87%.

@@            Coverage Diff             @@
##           master    #1898      +/-   ##
==========================================
+ Coverage   81.14%   81.69%   +0.54%     
==========================================
  Files         190      201      +11     
  Lines       19424    20460    +1036     
==========================================
+ Hits        15761    16714     +953     
- Misses       3199     3274      +75     
- Partials      464      472       +8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3d6fa1...7ac3e2b. Read the comment docs.

Looks like bin/fmt.sh check failed.

W1128 22:03:53.982] + git status
W1128 22:03:53.990] + die 'Repo has unstaged changes. Re-run ./bin/fmt.sh'
W1128 22:03:53.991] + echo 'Repo has unstaged changes. Re-run ./bin/fmt.sh'
W1128 22:03:53.991] + exit 1
I1128 22:03:53.991] On branch test
I1128 22:03:53.991] Changes not staged for commit:
I1128 22:03:53.991]   (use "git add <file>..." to update what will be committed)
I1128 22:03:53.992]   (use "git checkout -- <file>..." to discard changes in working directory)
I1128 22:03:53.992] 
I1128 22:03:53.992] 	modified:   Gopkg.lock
I1128 22:03:53.992] 	modified:   generated_files
I1128 22:03:53.992] 
I1128 22:03:53.992] no changes added to commit (use "git add" and/or "git commit -a")
I1128 22:03:53.993] Repo has unstaged changes. Re-run ./bin/fmt.sh
E1128 22:03:53.993] Build failed
I1128 22:03:53.993] process 513 exited with code 1 after 8.0m
E1128 22:03:53.993] FAIL: istio-presubmit

Thanks, I was searching around for bazel failures and missed that.

Presubmit appears to be failing because Gopkg.lock and generated_files are being changed? I don't touch them in this PR.

run_or_die_on_change ./bin/fmt.sh probably needs to run before dep ensure and bin/init.sh

/cc @jmuk

Why are we running any go commands at all as part of our presubmit? We have a single build system, bazel. This PR works under bazel. There is no reason we should be using any other tooling.

@ZackButcher PR needs rebase

fmt.sh relies on bazel, needs to run after init.sh. Didn't notice about Gopkg.lock changes can happen, but that file needs to be updated anyways, doesn't they?