Skip to content

added support for multiple TCP protocols in egress rules, including Mongo#1892

Closed
vadimeisenbergibm wants to merge 4 commits intoistio:masterfrom
vadimeisenbergibm:egress_mongo_support
Closed

added support for multiple TCP protocols in egress rules, including Mongo#1892
vadimeisenbergibm wants to merge 4 commits intoistio:masterfrom
vadimeisenbergibm:egress_mongo_support

Conversation

@vadimeisenbergibm
Copy link
Copy Markdown
Contributor

@vadimeisenbergibm vadimeisenbergibm commented Nov 28, 2017 •
edited
Loading

What this PR does / why we need it:
Adds support for multiple TCP protocols, with Mongo protocol being the first one to be added after TCP.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1476

Special notes for your reviewer:
This PR enables multiple TCP protocols, with Mongo being the first case. Redis will be added in a separate PR, after I test it.

Release note:

Added support for Mongo protocol in egress rules

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Nov 28, 2017

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: qiwzhang

Assign the PR to them by writing /assign @qiwzhang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 28, 2017

Codecov Report

Merging #1892 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1892      +/-   ##
==========================================
+ Coverage   81.67%   81.75%   +0.07%     
==========================================
  Files         201      198       -3     
  Lines       20447    19948     -499     
==========================================
- Hits        16701    16309     -392     
+ Misses       3275     3200      -75     
+ Partials      471      439      -32
Flag Coverage Δ
#broker 45.51% <ø> (ø) ⬆️
#mixer 83.21% <ø> (ø) ⬆️
#pilot 80.52% <100%> (+0.11%) ⬆️
#security 90.39% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pilot/model/validation.go 92.16% <100%> (ø) ⬆️
pilot/model/egress_rules.go 100% <100%> (ø) ⬆️
pilot/proxy/envoy/config.go 92.07% <100%> (-0.02%) ⬇️
pilot/platform/kube/inject/http.go
pilot/platform/kube/inject/inject.go
pilot/platform/kube/inject/configmap.go
pilot/platform/kube/inject/initializer.go
pilot/tools/version/version.go 100% <0%> (ø)
pilot/adapter/config/crd/controller.go 79.86% <0%> (+2.01%) ⬆️
mixer/adapter/stackdriver/metric/bufferedClient.go 92.5% <0%> (+2.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e36ed7b...a2228ed. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 28, 2017 •
edited
Loading

Codecov Report

Merging #1892 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1892     +/-   ##
=========================================
+ Coverage   81.14%   81.24%   +0.1%     
=========================================
  Files         187      191      +4     
  Lines       18883    19497    +614     
=========================================
+ Hits        15322    15841    +519     
- Misses       3128     3194     +66     
- Partials      433      462     +29
Flag Coverage Δ
#broker 45.51% <ø> (ø) ⬆️
#mixer 82.45% <ø> (+0.08%) ⬆️
#pilot 80.61% <100%> (+0.2%) ⬆️
#security 90.39% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pilot/model/egress_rules.go 100% <100%> (ø) ⬆️
pilot/proxy/envoy/config.go 92.07% <100%> (-0.02%) ⬇️
pilot/model/validation.go 92.16% <100%> (ø) ⬆️
pilot/adapter/config/ingress/conversion.go 100% <0%> (ø) ⬆️
mixer/adapter/svcctrl/svcctrl.go 61.16% <0%> (ø) ⬆️
pilot/proxy/envoy/policy.go 88.73% <0%> (ø) ⬆️
pilot/proxy/envoy/ingress.go 75.55% <0%> (ø) ⬆️
pilot/platform/kube/inject/http.go 75.86% <0%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb8bff0...597e188. Read the comment docs.

@vadimeisenbergibm vadimeisenbergibm changed the title [WIP] added support for multiple TCP protocols in egress rules, including Mongo added support for multiple TCP protocols in egress rules, including Mongo Nov 28, 2017
@vadimeisenbergibm
Copy link
Copy Markdown
Contributor Author

vadimeisenbergibm commented Nov 28, 2017

/test istio-presubmit

@ijsnellf
Copy link
Copy Markdown
Contributor

ijsnellf commented Nov 28, 2017

Add a release note?

@vadimeisenbergibm
Copy link
Copy Markdown
Contributor Author

vadimeisenbergibm commented Nov 28, 2017

@ijsnellf I have fixed the RELEASE NOTE, sorry.

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Nov 29, 2017

@vadimeisenbergibm PR needs rebase

@istio-merge-robot istio-merge-robot added the needs-rebase Indicates a PR needs to be rebased before being merged label Nov 29, 2017
@istio-merge-robot istio-merge-robot removed the needs-rebase Indicates a PR needs to be rebased before being merged label Nov 29, 2017
@vadimeisenbergibm vadimeisenbergibm mentioned this pull request Nov 29, 2017
Merged
@vadimeisenbergibm
Copy link
Copy Markdown
Contributor Author

vadimeisenbergibm commented Nov 29, 2017

Rebased and resubmitted by #1913.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ijsnellf ijsnellf Awaiting requested review from ijsnellf

1 more reviewer

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Egress rule must support Mongo/Redis/TCP services

6 participants

@vadimeisenbergibm @istio-merge-robot @ijsnellf @rshriram @googlebot @istio-testing