Skip to content

Update the Prometheus image to v2.0.0#1864

Merged
rshriram merged 1 commit intoistio:masterfrom
simonpasquier:update-prometheus-image
Nov 28, 2017
Merged

Update the Prometheus image to v2.0.0#1864
rshriram merged 1 commit intoistio:masterfrom
simonpasquier:update-prometheus-image

Conversation

@simonpasquier
Copy link
Copy Markdown
Contributor

@simonpasquier simonpasquier commented Nov 27, 2017

What this PR does / why we need it:

This PR updates the Prometheus image to the latest table version.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

I haven't tested it yet but it should be relatively safe. The CLI flags have been updated to match with the v2.0.0 version.

Release note:

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Nov 27, 2017

@simonpasquier: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

Details

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@googlebot
Copy link
Copy Markdown
Collaborator

googlebot commented Nov 27, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Nov 27, 2017
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Nov 27, 2017

Hi @simonpasquier. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@simonpasquier simonpasquier force-pushed the update-prometheus-image branch from 2a4218e to 58950c7 Compare November 27, 2017 15:48
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 27, 2017 •
edited
Loading

Codecov Report

Merging #1864 into master will increase coverage by 0.7%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1864     +/-   ##
=========================================
+ Coverage   81.16%   81.87%   +0.7%     
=========================================
  Files         189      185      -4     
  Lines       19396    18155   -1241     
=========================================
- Hits        15743    14864    -879     
+ Misses       3187     2895    -292     
+ Partials      466      396     -70
Flag Coverage Δ
#broker 45.51% <ø> (ø) ⬆️
#mixer 82.46% <ø> (ø) ⬆️
#pilot 82.24% <ø> (+1.84%) ⬆️
#security 90.39% <ø> (ø) ⬆️
Impacted Files Coverage Δ
mixer/adapter/svcctrl/handler.go 23.8% <0%> (-11.33%) ⬇️
pilot/platform/kube/queue.go 82.69% <0%> (-7.7%) ⬇️
pilot/platform/eureka/controller.go 85% <0%> (-7.5%) ⬇️
mixer/adapter/prometheus/server.go 89.83% <0%> (-5.09%) ⬇️
mixer/adapter/svcctrl/reportbuilder.go 83.87% <0%> (-3.63%) ⬇️
pilot/platform/kube/controller.go 51.85% <0%> (-3.04%) ⬇️
pilot/model/conversion.go 83.09% <0%> (-2.27%) ⬇️
pilot/platform/consul/conversion.go 87.03% <0%> (-2.22%) ⬇️
pilot/platform/eureka/conversion.go 84.84% <0%> (-0.04%) ⬇️
mixer/cmd/client/cmd/util.go 61.92% <0%> (ø) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8743921...1d22a1b. Read the comment docs.

@douglas-reid
Copy link
Copy Markdown
Contributor

douglas-reid commented Nov 27, 2017

/ok-to-test

@douglas-reid douglas-reid self-assigned this Nov 27, 2017
@douglas-reid
Copy link
Copy Markdown
Contributor

douglas-reid commented Nov 27, 2017

/test istio-pilot-e2e

douglas-reid
douglas-reid reviewed Nov 28, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@douglas-reid douglas-reid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@simonpasquier
Update the Prometheus image to v2.0.0
1d22a1b 
The CLI flags have been modified accordingly.
@simonpasquier simonpasquier force-pushed the update-prometheus-image branch from 58950c7 to 1d22a1b Compare November 28, 2017 14:33
@googlebot
Copy link
Copy Markdown
Collaborator

googlebot commented Nov 28, 2017

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Nov 28, 2017
@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Nov 28, 2017

/lgtm cancel //PR changed after LGTM, removing LGTM. @douglas-reid @simonpasquier

@douglas-reid
Copy link
Copy Markdown
Contributor

douglas-reid commented Nov 28, 2017

/lgtm

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Nov 28, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: douglas-reid

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@rshriram rshriram merged commit 4a0c241 into istio:master Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@douglas-reid douglas-reid douglas-reid left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@douglas-reid douglas-reid

Labels

do-not-merge/post-submit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@simonpasquier @istio-testing @googlebot @douglas-reid @istio-merge-robot @rshriram @yutongz