Add back applicationPorts function to the injector (fixes test)#18352
Merged
istio-testing merged 1 commit intoistio:masterfrom Oct 28, 2019
Merged
Conversation
This was removed in istio#17986. The removal was not neccesarily wrong, but it means that the injector deployment and injection template need to move in lock step, which has some problems. Specifically, the operator did not have charts updated, so it fails now, and anyone using :latest tags will also fail without updating the template. There is a near-zero cost of keeping the function around, so we might as well add it back to make things a bit simpler.
hzxuzhonghu
approved these changes
Oct 26, 2019
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
geeknoid
approved these changes
Oct 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was removed in #17986. The
removal was not neccesarily wrong, but it means that the injector
deployment and injection template need to move in lock step, which has
some problems. Specifically, the operator did not have charts updated,
so it fails now, and anyone using :latest tags will also fail without
updating the template.
There is a near-zero cost of keeping the function around, so we might as
well add it back to make things a bit simpler.