Incremental changes for istiod#18132
Conversation
- remove the SDS startup in pilot - the feedback is to start with SDS in agent, pilot will only sign certs. - cleanup a bit the startup - use port 8080 for http - istioctl expects it. - add the original Dockerfile - while it is getting integrated into the istio build system ( can be useful after as well, it's very easy)
|
/retest |
| //RunValidation start running Galley validation mode | ||
| func RunValidation(ready chan<- struct{}, stopCh chan struct{}, vc *WebhookParameters, kubeConfig string, | ||
| livenessProbeController, readinessProbeController probe.Controller) { | ||
| func RunValidation(ready chan<- struct{}, stopCh chan struct{}, vc *WebhookParameters, kubeInterface *kubernetes.Clientset, kubeConfig string, livenessProbeController, readinessProbeController probe.Controller) { |
There was a problem hiding this comment.
Can you replace kubeconfig with kubeInterface? We don't need to support both.
There was a problem hiding this comment.
I'll leave it to a Galley expert - I tried to minimize risks to existing code paths ( which may eventually go away ). The kubeconfig string is used deep in the code.
I think the biggest issue is getting Interfaces() to use the kubernetes.Interface instead of the config, so a single client is used.
|
/retest |
|
/test lint_istio |
|
/test e2e-simpleTests-distroless_istio |
|
@costinm I am a bit confused, I was under impression that no webhook related work has already being done, also I thought the direction was to have webhook as a separate package and call its functions from istiod while have webhook in Galley disabled. |
|
@costinm you have some merge conflicts |
|
/retest |
|
@costinm: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
agent, pilot will only sign certs.
istio build system ( can be useful after as well, it's very easy)
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure